Skip to content

fix: use Alternative when Buffer not available like CF #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riderx wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: use Alternative when Buffer not available like CF #6

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a8b8bd
fix: add explicit import to support CF workers
riderx Aug 14, 2024
406bca2
fix: use old shool one to pass tests
riderx Aug 14, 2024
dec0c92
fix: solve portability better by using btoa when available
riderx Aug 14, 2024
fe9ac14
fix: add fallback implementation for others env
riderx Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions src/sdk/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,31 @@ import fetch from 'cross-fetch';
import type { AnalyticsOptions, AuthenticationOptions } from '../interfaces';
import { NotAuthorizedError, RateLimitedError } from './errors';

function encodeBase64(str: string): string {
if (typeof btoa === 'function') {
return btoa(str);
} else if (typeof Buffer !== 'undefined') {
return Buffer.from(str).toString('base64');
} else {
// Fallback implementation
const chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=';
let output = '';
for (let block = 0, charCode, i = 0, map = chars;
str.charAt(i | 0) || (map = '=', i % 1);
output += map.charAt(63 & block >> 8 - i % 1 * 8)) {

charCode = str.charCodeAt(i += 3/4);

if (charCode > 0xFF) {
throw new Error("'btoa' failed: The string to be encoded contains characters outside of the Latin1 range.");
}

block = block << 8 | charCode;
}
return output;
}
}

export class BentoClient {
private readonly _headers: HeadersInit = {};
private readonly _baseUrl: string = 'https://app.bentonow.com/api/v1';
Expand Down Expand Up @@ -89,9 +114,8 @@ export class BentoClient {
* @returns HeadersInit
*/
private _extractHeaders(authentication: AuthenticationOptions): HeadersInit {
const authenticationKey = Buffer.from(
`${authentication.publishableKey}:${authentication.secretKey}`
).toString('base64');
const authenticationKey = encodeBase64(`${authentication.publishableKey}:${authentication.secretKey}`);


return {
Authorization: `Basic ${authenticationKey}`,
Expand Down