Parity feature implementation against the API #21
Merged
Conversation
Add optional pagination support to Sequences and Workflows fetch
endpoints by introducing GetSequencesParameters and
GetWorkflowsParameters types with a page?: number field. Update the
BentoSequences.getSequences and BentoWorkflows.getWorkflows methods to
accept an optional parameters object and forward it to the client's GET
call. Adjust imports and types accordingly.
Also expand README docs for Sequences: add a higher-level description,
show example usage with Analytics client, demonstrate passing { page }
for pagination, and enrich example response and createSequenceEmail
documentation to better reflect real-world fields and links to API
docs.
This enables callers to paginate large installs and documents usage in
the SDK README.
Ensure query parameters with null or undefined values are skipped when serializing request bodies into URLSearchParams. This prevents literal "null" or empty parameters from being sent and aligns behavior with expected API semantics. Add tests and test helpers to verify the change: - export lastFetchUrl from mockFetch helper to inspect the request URL. - add a test that confirms undefined SDK options (page) are omitted from the query string. - assert site_uuid is correctly set and not the string "null". This fixes incorrect query parameter serialization and adds coverage to prevent regressions.
feat(sequences/workflows): add optional pagination to fetch APIs
Confidence Score: 5/5
Last reviewed commit: 095ed2b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional pagination support to Sequences and Workflows fetch
endpoints by introducing GetSequencesParameters and
GetWorkflowsParameters types with a page?: number field. Update the
BentoSequences.getSequences and BentoWorkflows.getWorkflows methods to
accept an optional parameters object and forward it to the client's GET
call. Adjust imports and types accordingly.
Also expand README docs for Sequences: add a higher-level description,
show example usage with Analytics client, demonstrate passing { page }
for pagination, and enrich example response and createSequenceEmail
documentation to better reflect real-world fields and links to API
docs.
This enables callers to paginate large installs and documents usage in
the SDK README.