Add attachment content signature transform - #60
Open
NathanBerthier wants to merge 2 commits into
Open
Conversation
Owner
|
Hi, That link doesn't work so I can verify :) |
NathanBerthier
force-pushed
the
add-attachment-content-signature-transform
branch
from
September 2, 2025 08:25
6b69a7d to
2b09307
Compare
Owner
|
Also do you have an example on what XML this can sign |
Author
Hello 👋 Thank you for the quick reply 😃 I did open the PR as a draft to do some testing first, but I'll write some specs and provide example of XML later |
NathanBerthier
marked this pull request as ready for review
September 2, 2025 12:55
Author
|
@benoist I've added some specs and an example of unsigned xml, let me know if you need more context |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new transform (http://docs.oasis-open.org/wss/oasis-wss-SwAProfile-1.1#Attachment-Content-Signature-Transform)