Skip to content

Fix design-mode svg[fill="none"] leaking into host page (#181) #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcamarajr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix design-mode svg[fill="none"] leaking into host page (#181) #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions package/src/components/design-mode/styles.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,19 @@
// Layout Mode Styles
// =============================================================================

// Protect stroke-based SVG icons from host page CSS overrides
svg[fill="none"] {
fill: none !important;
// Protect stroke-based SVG icons from host page CSS overrides.
// Scoped to design-mode's own containers to avoid breaking host SVGs that use
// fill="none" with CSS-based fills (e.g. Tailwind's fill-current).
// See: https://github.com/benjitaylor/agentation/issues/181
.overlay,
.rearrangeOverlay {
svg[fill="none"] {
fill: none !important;
}

svg[fill="none"] :not([fill]) {
fill: none !important;
}
}

$blue: #3c82f7;
Expand Down