ThreadLock::new — use RAII for ptrace detach cleanup (#117)#118
Open
charles-dyfis-net wants to merge 1 commit into
Open
ThreadLock::new — use RAII for ptrace detach cleanup (#117)#118charles-dyfis-net wants to merge 1 commit into
ThreadLock::new — use RAII for ptrace detach cleanup (#117)#118charles-dyfis-net wants to merge 1 commit into
Conversation
Owner
|
Thanks for the change! I like the core fix here - but running the new test locally and I'm seeing some intermittent failures on my local ubuntu machine (fails maybe 1/8th of the time for me). The failures look like |
Owner
|
btw, I think the GHA build failure is unrelated to this PR and I will fix this up in a separate PR |
Construct `ThreadLock { tid }` immediately after a successful `ptrace::seize` so that `Drop` becomes responsible for detach on every exit path, including `?` propagation. Closes all three error paths listed in benfred#117 with a single change.
23a3c48 to
6969c4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construct
ThreadLock { tid }immediately after a successfulptrace::seizeso thatDropbecomes responsible for detach on every exit path, including?propagation. Closes all three error paths listed in #117 with a single change.