[codex] Add keybinding conflict warnings - #95
Open
bendsp wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds duplicate-keybinding detection to the renderer so users can see conflicts directly in the Settings modal, with accompanying unit tests to prevent regressions.
Changes:
- Added
findKeyBindingConflicts()to detect duplicate normalized bindings across actions. - Updated keybinding settings rows to display a per-action “Conflicts with …” warning.
- Added unit tests for conflict detection and wired them into the unit test entrypoint.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/keybindings.test.ts | Adds unit coverage for conflict detection and the no-conflicts case. |
| tests/index.ts | Registers the new keybindings unit test file in the test runner. |
| src/renderer/keybindings.ts | Adds findKeyBindingConflicts() and hardens platform detection for non-browser runtimes. |
| src/renderer/components/SettingsModal.tsx | Computes conflicts from current settings and renders conflict warnings in keybinding rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation