Skip to content

[codex] Add keybinding conflict warnings - #95

Open
bendsp wants to merge 1 commit into
codex/editor-quality-passfrom
codex/feature-keybinding-conflict-warning
Open

[codex] Add keybinding conflict warnings#95
bendsp wants to merge 1 commit into
codex/editor-quality-passfrom
codex/feature-keybinding-conflict-warning

Conversation

@bendsp

@bendsp bendsp commented May 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • detect duplicate normalized keybindings across configured actions
  • show conflict warnings directly in the keybinding settings rows
  • add unit coverage for conflict detection and unique binding behavior

Validation

  • pnpm lint
  • pnpm typecheck
  • pnpm test:unit

Copilot AI review requested due to automatic review settings May 9, 2026 14:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds duplicate-keybinding detection to the renderer so users can see conflicts directly in the Settings modal, with accompanying unit tests to prevent regressions.

Changes:

  • Added findKeyBindingConflicts() to detect duplicate normalized bindings across actions.
  • Updated keybinding settings rows to display a per-action “Conflicts with …” warning.
  • Added unit tests for conflict detection and wired them into the unit test entrypoint.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/keybindings.test.ts Adds unit coverage for conflict detection and the no-conflicts case.
tests/index.ts Registers the new keybindings unit test file in the test runner.
src/renderer/keybindings.ts Adds findKeyBindingConflicts() and hardens platform detection for non-browser runtimes.
src/renderer/components/SettingsModal.tsx Computes conflicts from current settings and renders conflict warnings in keybinding rows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants