[codex] Improve code block insertion - #94
Open
bendsp wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the CodeMirror “fenced code block” toggle command so that when invoked on a blank/whitespace-only line with an empty selection, it inserts an empty fenced code block and places the cursor inside it (while preserving the line’s indentation).
Changes:
- Add a special-case path in
toggleFencedCodeBlockCommandfor empty selections on blank lines to insert an editable empty fenced block and move the cursor into it. - Preserve leading indentation when inserting an empty fenced block snippet.
- Add unit tests covering empty-block insertion, cursor placement, and indentation preservation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/renderer/editor/codemirror/commands.ts |
Adds blank-line empty-selection handling to insert an indented empty fenced block and position the cursor inside it. |
tests/controllerShortcuts.test.ts |
Adds unit tests validating the new empty fenced block insertion behavior and cursor position. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation