Adding feature to save account#9
Conversation
|
@arloncunha Love it mate! Great work, thanks so much! |
…ntries parameter do exists
arloncunha
force-pushed
the
feature/SaveAccount
branch
from
94d6095 to
dba365d
Compare
| tabId: 0, | ||
| frameId: 0, | ||
| payload: JSON.stringify({ | ||
| QID: "CmdNewAccount4URL", |
There was a problem hiding this comment.
Hey ^^. I have implemented this feature as well on my end before knowing of this PR. I have had a look at the Apple Passwords extension for chrome and investigated the commands used there to set a new password. Instead of the NEW_ACCOUNT_FOR_URL (7) command, it uses the SET_PASSWORD_FOR_LOGIN_NAME_AND_URL (6) command, even when setting passwords for sites that you have not had a password for prior. Also, instead of CmdNewAccount4URL in the payload, it uses CmdSetPassword4LoginName_URL.
While comparing your approach and "mine" I discovered that both work fine in all cases, however in "mine" you do not have to biometrically authenticate, i.e., touch id. You only need to click away the notice just as you would have to in your approach after biometrically authenticating. Therefore, I think that "my" approach is a little simpler.
I agree with everything else on this PR tho ^^.
There was a problem hiding this comment.
thx for feedback @maxloeffler, it makes sense to me.
waiting for a fix on this issue #10 in order to test and push an update with your suggestions.
3 participants
@bendews, hope you like it 👍
Implemented save to account feature per #8
TL;DR
it doesn't validate if account tuple (url, loginname, password) already exists which means it can create or update the account seamlessly.
creating account...
updating password...
1.0.2