Supports the display of a dial for the management of the 24h (without AM and PM)#52
Open
stephanebalasse wants to merge 6 commits into
Open
Supports the display of a dial for the management of the 24h (without AM and PM)#52stephanebalasse wants to merge 6 commits into
stephanebalasse wants to merge 6 commits into
Conversation
stephanebalasse
commented
Apr 10, 2017
stephanebalasse
commented
added 6 commits
April 7, 2017 08:51
# Conflicts: # demo/index.html # package.json # paper-clock-selector.html # paper-time-picker.html
bendavis78
requested changes
Jul 9, 2017
bendavis78
left a comment
bendavis78
left a comment
Owner
There was a problem hiding this comment.
- Please remove unnecessary files (.idea/ dir?)
- Remove changes that only affect whitespace
- Don't change the version number (this will be done after final merge)
- Don't change indentation so that it's clear which lines of code have been changed
admwx7
requested changes
Sep 14, 2017
admwx7
left a comment
admwx7
left a comment
Collaborator
There was a problem hiding this comment.
- remove editor based files - I recommend a .gitignore files in your userspace to remove them on app projects
- remove random white space changes, indention changes, and new lines
- L224 paper-time-picker.html is forcing this to always be 24hrs, this should be something you opt into
|
I'm pretty sad that this PR was never merged. 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.