FIX benchopt tests#40
Merged
Merged
Conversation
tomMoral
commented
Jun 8, 2026
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Closed
felixdivo
added a commit
to felixdivo/benchmark_tsfm
that referenced
this pull request
Jun 8, 2026
Resolve conflicts from main's "FIX benchopt tests (benchopt#40)". All conflicts were the quantile-axis convention: the branch uses quantiles-last (n_cutoffs, H, C, Q) while main only reformatted the old quantiles-second (n_cutoffs, Q, H, C) layout — kept the branch's convention everywhere (naive, seasonal_naive, tfc_api, metrics, outputs, base_solver, leakage tests). For chronos2.py both sides independently rebased onto BaseTSFMAdapter; kept the branch's typed predict + quantiles-last _assemble_output and switched to the centralized POOLERS from benchmark_utils.adapters (dropping the duplicate local dict / imports). Wrapped two over-length lines in base_solver.py to satisfy ruff E501. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.