Skip to content

feat(shell): improve shell detection with direct environment checks #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbenbang merged 1 commit into from
Mar 27, 2026
Merged

feat(shell): improve shell detection with direct environment checks #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,19 @@ fn get_venv_path() -> PathBuf {
}

/// Auto-detect the current shell from environment.
///
/// Check order:
/// 1. `$FISH_VERSION` — set by fish itself, reliable even when $SHELL lags
/// 2. `$NU_VERSION` — set by nushell
/// 3. `$SHELL` — login shell; may differ from the running shell
/// 4. `$PSModulePath` — PowerShell
fn detect_shell() -> &'static str {
if env::var("FISH_VERSION").is_ok() {
return "fish";
}
if env::var("NU_VERSION").is_ok() {
return "nushell";
}
if let Ok(shell) = env::var("SHELL") {
if shell.contains("fish") {
return "fish";
Expand Down
Loading