feat(venv): add upward directory traversal for .venv discovery - #22
Merged
Conversation
This pull request enhances the anchor command to search for virtual environments by traversing up the directory tree, rather than only checking the current directory. The main changes improve usability when working in project subdirectories. **Virtual environment discovery enhancement:** * Added a new `find_venv_upward` function in `src/main.rs` that walks from the current directory up to the filesystem root looking for `.venv/pyvenv.cfg`, enabling anchor to work from any subdirectory within a project. * Refactored the `anchor` function to use `find_venv_upward` instead of only checking the current directory, with improved error messaging that indicates the traversal behavior. **Testing improvements:** * Added a new integration test `anchor_finds_venv_in_parent_directory` in `tests/integration.rs` that verifies the anchor command correctly finds `.venv` when executed from nested subdirectories and sets VIRTUAL_ENV to the correct root path. * Updated existing test assertions to verify the new error message mentions "or any parent directory" when no .venv is found. * Added cleanup of temporary directories in existing tests to prevent resource leaks.
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the anchor command to search for virtual environments by traversing up the directory tree, rather than only checking the current directory. The main changes improve usability when working in project subdirectories.
Virtual environment discovery enhancement:
find_venv_upwardfunction insrc/main.rsthat walks from the current directory up to the filesystem root looking for.venv/pyvenv.cfg, enabling anchor to work from any subdirectory within a project.anchorfunction to usefind_venv_upwardinstead of only checking the current directory, with improved error messaging that indicates the traversal behavior.Testing improvements:
anchor_finds_venv_in_parent_directoryintests/integration.rsthat verifies the anchor command correctly finds.venvwhen executed from nested subdirectories and sets VIRTUAL_ENV to the correct root path.