fix(venv): filter --prefix flag before forwarding to uv venv#16
Merged
Conversation
This commit prevents the custom --prefix flag from being passed to the underlying `uv venv` command, which does not recognize it. The changes ensure that only valid arguments are forwarded during virtual environment creation. **Argument filtering logic:** * Added filtering logic in `src/main.rs` to strip both `--prefix` and `--prefix=value` forms from user arguments before passing them to `create_venv()`. * The filtered arguments are collected into a new vector that excludes the custom flag and its value, preventing errors from the underlying `uv venv` command.
benbenbang
enabled auto-merge (squash)
March 26, 2026 17:48
|
🎉 This PR is included in version 2.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit prevents the custom --prefix flag from being passed to the underlying
uv venvcommand, which does not recognize it. The changes ensure that only valid arguments are forwarded during virtual environment creation.Argument filtering logic:
src/main.rsto strip both--prefixand--prefix=valueforms from user arguments before passing them tocreate_venv().uv venvcommand.