feat(parser): smarter exercise-name normalization (#19, partial) - #46
Merged
Conversation
…w catalog entries Expands built-in aliases (bp, bb bench press, strict press, oh press, legpress, backsquat, bb dl …) and adds face-pull, hack-squat, hammer-curl, preacher-curl as first-class catalog entries (with correct muscle attribution). Recovers issue #19 normalization work from an interrupted session, re-based clean on current main. Data-only — no match-logic change. 391 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers the exercise-name-normalization core from an interrupted session (the
f19worktree had ~5h-stale uncommitted WIP, no live process), re-based clean on currentmain.Adds (data-only — no match-logic change)
bp,bb bench press,strict press,oh press,legpress,backsquat,bb dl, etc.Verified
391 tests pass, no regressions. Smoke:
bp→barbell-bench-press,strict press→overhead-press,hammer curl→hammer-curl,face pull→face-pull — all previouslyunknown:.Not included
The interrupted session also had a competing
exerciseLine.tstokenizer rewrite (@ weight, rep ranges, AMRAP, lb→kg, RPE, drop sets) on the pre-#44 base — conflicts with the #44 tokenizer. A separate follow-up.