Remove dependency on gulp-util - #11
Open
jonpearse wants to merge 2 commits into
Open
Conversation
gulp-util is not only long-deprecated, but relies on a version of lodash.template with severe vulnerability issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gulp-utilwas deprecated a while back, and while this isn’t the end of the world, it in turn unfortunately depends on a version of lodash with a critical vulnerability.This was causing security alerts on a project I’m working on, and in turn was causing our CTO to jump up and down in an amusingly animated manner :)
Either way, I’ve switched out
replaceExtensioncalls to use thereplace-extmodule, andgutil.Fileto use standard Vinyl objects. I also switched instances ofnew Buffer()toBuffer.from(string)to get rid of some deprecation warnings.I’ve not bumped any other deps—I’ll leave that to your discretion. Tests seem to pass OK, but apologies in advance if I’ve missed anything else.
Otherwise, thanks for making this plugin—switching to it shaved a couple minutes off our project’s build time, which makes me all kinds of happy!