docs(27): ADR-004 — partial overturn of project_redis_shaped_no_event_time_ever#150
Open
petrpan26 wants to merge 2 commits into
Open
docs(27): ADR-004 — partial overturn of project_redis_shaped_no_event_time_ever#150petrpan26 wants to merge 2 commits into
petrpan26 wants to merge 2 commits into
Conversation
…_time_ever
phase12_6_mio_only_dataplane.rs lines 14 and 148 are annotated with
the partial-overturn note for v0.1 event-time bucketing. The tripwire's
symbol-search assertion logic is untouched; only the doc-comment and
assertion-message string are modified. cargo test
-p beava-server --test phase12_6_mio_only_dataplane: 3 passed, 0 failed.
Companion local-only working state (not committed; CLAUDE.md and the
ADR are both gitignored on this branch per the filter-repo rewrite +
.planning/ gitignore):
- .planning/decisions/ADR-004-event-time-bucketing-partial-overturn.md
(new — Nygard scaffold: Status / Context / Decision / Consequences;
IN bullets C-01..C-04; 5 STAYS OUT per-surface rationale blocks)
- CLAUDE.md gains a §Event-Time Scope (v0.1, ADR-004) block adjacent
to §mio-only and §Events-Only, plus a footnote under each existing
block's **Why:** line clarifying that event-time bucketing flows
through the same mio path and adds no tables — the invariants are
unaffected.
Phase 27 / Plan 27-01. Doc-only-plan exemption per CLAUDE.md §TDD
Discipline item #7 (verbatim citation for plan-checker grep).
Contributor
|
Related Knowledge 5 documents with suggested updates are ready for review. beava compilation-rules
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 27 architectural-decision gate for v0.1 (Pragmatic Event-Time Windowing). Annotates the
phase12_6_mio_only_dataplane.rsarchitectural tripwire with a partial-overturn note pointing at ADR-004.The ADR itself lives at
.planning/decisions/ADR-004-event-time-bucketing-partial-overturn.md(gitignored.planning/); CLAUDE.md amendment lives in local working state (also gitignored on this branch). This PR carries the single git-tracked artifact from Phase 27.What changed
crates/beava-server/tests/phase12_6_mio_only_dataplane.rslines 14 + 148 — doc-comment + assertion-message prose annotated:(post-2026-05-19: partially overturned by ADR-004 for v0.1 bucketing)cargo test -p beava-server --test phase12_6_mio_only_dataplane: 3 passed, 0 failedTest plan
cargo test -p beava-server --test phase12_6_mio_only_dataplane— 3 passedContext
Phase 27 closes the v0.1 architectural-decision gate. ADR-004 records the partial overturn of
project_redis_shaped_no_event_time_ever— pragmatic event-time bucketing via reserved_tsis IN for v0.1; watermarks / out-of-order buffering / late-event side-output / PIT temporal store / stream-stream joins stay OUT. Phases 28–32 (wire / apply / WAL+recovery / Python SDK / acceptance) will cite ADR-004 §IN rather than re-derive scope.Doc-only-plan exemption per CLAUDE.md §TDD Discipline item #7.