Add transaction by reference#2267
Open
mocsa wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is preparatory work to enable the duplication of Transactions, Balances, and Notes.
This is a much simpler approach than what I followed in #2226. It takes inspiration from Context.svelte. It reads the entry_hash from the URL and loads it into the Add dialog. The URL should look like https://server/beancountfile/account/Assets:Bank:Checking#add-transaction-from-cf93b24126f19dadf05c5a1f35a8af93
I took your advice @yagebu in #2226 to replace EntryBaseValidator with EntryValidator to keep all data that is returned by get_context().
Currently, this functionality will not be used in fava, but I thought I submit it separately to make review easier. I plan to submit the related GUI modification after this PR is merged.