Skip to content

NumberBox Focus#1341

Merged
bdlukaa merged 2 commits into
bdlukaa:masterfrom
WinXaito:hotfix/numberbox_focus
Jul 8, 2026
Merged

NumberBox Focus#1341
bdlukaa merged 2 commits into
bdlukaa:masterfrom
WinXaito:hotfix/numberbox_focus

Conversation

@WinXaito

@WinXaito WinXaito commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

During #1332 I forgot to try with clearButton: true.

Before:

NB_BEFORE.mp4

After:

NB_AFTER.mp4

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NumberBox widget in lib/src/controls/form/number_box.dart by setting focusable: false on the clear button, preventing it from receiving focus. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@WinXaito WinXaito requested a review from bdlukaa July 8, 2026 12:20
@bdlukaa bdlukaa merged commit cfb8c40 into bdlukaa:master Jul 8, 2026
3 checks passed
@WinXaito WinXaito deleted the hotfix/numberbox_focus branch July 8, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants