fix: use session-specific EIP-712 signing without MeeUserOp timestamps#201
Open
fichiokaku wants to merge 3 commits into
Open
fix: use session-specific EIP-712 signing without MeeUserOp timestamps#201fichiokaku wants to merge 3 commits into
fichiokaku wants to merge 3 commits into
Conversation
size-limit report 📦
|
vr16x
reviewed
Apr 7, 2026
| return await signQuote(client, { | ||
| quote: quote as GetQuotePayload | ||
| }) | ||
| const simpleQuote = quote as GetQuotePayload |
Collaborator
There was a problem hiding this comment.
Can we use this inside the signQuote itself only for smart sessions flow ?
Currently the legacy smart sessions flow might break because it uses EIP 712 and our server goes with NoMeeMode.
Adding this inside signQuote with a special flag for smart sessions will apply this for all the smart sessions flows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances the
signSessionQuoteandsignQuotefunctionalities by introducing support for MEE version 2.2.1 and above, allowing for personal signing on raw hashes for simple mode using smart sessions. It also refines signature handling based on session details.Detailed summary
versionIsAtLeast,isP256Signer, andMEEVersion.signSessionQuoteto handle MEE >= 2.2.1 with personal signing.signQuoteto check for session details and use NoMee flow for signing.