fix: add pg8000 graceful shutdown on Cloud Run scale-down#270
Open
panish16 wants to merge 8 commits into
Open
Conversation
Calls setup_pg8000_close_event_listener(engine) after db init in notify-api and notify-delivery so pg8000 InterfaceError is suppressed instead of logged as an error when SQLAlchemy closes pooled connections during teardown. Resolves #33564
Covers all branches of _setup_pg8000_graceful_shutdown: non-pg8000 early return, listener registration, normal close, InterfaceError suppression, re-raise of other errors, and ImportError fallback. Also renames _InterfaceError to _interface_error to satisfy naming linter rules.
…n doc-api Replace local _setup_pg8000_graceful_shutdown copy with the shared setup_pg8000_close_event_listener from sbc-connect-common/cloud-sql-connector (main branch, v0.2.3). Matches the approach used by notify-api, notify-delivery, and the lear queue services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_setup_pg8000_graceful_shutdowntodoc-api/create_app()to suppresspg8000.exceptions.InterfaceErrorduring Cloud Run scale-downdriver == "pg8000"guardServices fixed
Test plan
pg8000.exceptions.InterfaceErrorentries in GCP Log Explorer forc4hnrd-prodproject after deployment