Always have Submit button enabled; now use localStorage#707
Open
ionwyn wants to merge 5 commits into
Open
Conversation
Signed-off-by: Ionwyn Sean <ionwynsean@gmail.com>
Failed submissions now display the server's error/detail/title (and status code) instead of 'undefined' when the response body has no 'error' field, such as 401 and 400 rejections. Network failures fall back to the error message.
A missing Service Area now scrolls the dropdown into view and shows its required-field error on submit, instead of the submit silently doing nothing because the dropdown had no queryable input to scroll to.
A stored value that no longer matches any option (e.g. a stale or reassigned service area) now falls back to the default title instead of throwing and triggering the app-wide error boundary that blanked the form.
The locally stored draft is now removed once a report is submitted successfully, so reopening the form starts blank and contractors don't accidentally resubmit the same report. The storage key is exported from the form component to keep a single source of truth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.