Skip to content

DBC22-6585: highlighted advisory for new updates#1371

Draft
bcgov-brwang wants to merge 4 commits into
mainfrom
feature/DBC22-6585
Draft

DBC22-6585: highlighted advisory for new updates#1371
bcgov-brwang wants to merge 4 commits into
mainfrom
feature/DBC22-6585

Conversation

@bcgov-brwang

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No)

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Step one...
  2. Step two...

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

Comment thread src/frontend/src/Components/advisories/AdvisoriesList.js Fixed
Comment thread src/frontend/src/Components/advisories/AdvisoriesList.js Fixed
Comment thread src/frontend/src/pages/AdvisoriesListPage.js Fixed
@@ -1,5 +1,5 @@
// React
import React, { useContext } from 'react';
import React, { useContext, useRef } from 'react';
Comment thread src/frontend/src/pages/AdvisoriesListPage.js Fixed
DBC22-6585: highlighted advisory for new updates 2

DBC22-6585: highlighted bulletin for new updates

def publish_minor_update(request, page_id):
if request.method != "POST":
return redirect(f"/drivebc-cms/pages/{page_id}/edit/")
)

messages.success(request, f'"{page.title}" published as a minor update.')
return redirect(f"/drivebc-cms/pages/{page_id}/edit/")
Comment thread src/frontend/src/pages/AdvisoriesListPage.js Fixed
isInitialLoad.current = false;
isInitialMount.current = false;
setShowLoader(false);
}
// React
import React, { useCallback, useContext, useEffect, useRef, useState } from 'react';
import { useSearchParams } from "react-router-dom";
import { useSearchParams, useLocation } from "react-router-dom";
}, [advisories]);

// Handlers
const updateHighlightHandler = (updated) => {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants