fix: add missing edid exports to _pkgdown.yml reference index#265
Closed
Copilot wants to merge 2 commits into
Closed
fix: add missing edid exports to _pkgdown.yml reference index#265Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
The build-check CI job was failing because PR #260 adds 16 new exported edid functions (edid, aggte_edid, as_MP_edid, and S3 methods/tools) that were missing from the _pkgdown.yml reference index. pkgdown requires all exported topics to be listed in _pkgdown.yml or marked @Keywords internal. Added them in three new sections: - DiD Methods: edid, aggte_edid, as_MP_edid (alongside att_gt/aggte) - Efficient DiD methods: print/summary/coef/vcov/as.data.frame + weights - Efficient DiD specification testing: hausman/sargan/adaptive/frontier/bootstrap
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job build-check
fix: add missing edid exports to _pkgdown.yml reference index
Jun 17, 2026
pedrohcgs
added a commit
to marcelortizv/did
that referenced
this pull request
Jun 17, 2026
…heck pkgdown fix)
pkgdown::build_site() (the build-check job) requires every exported, documented
topic to appear in the reference index; PR260's 16 new edid exports were missing,
so build_reference_index() failed ("Reference metadata not ok ... 16 topics
missing from index"). Add them in three sections (equivalent to the independent
Copilot fix in PR bcallaway11#265): edid / aggte_edid / as_MP_edid alongside att_gt / aggte;
an "Efficient DiD: Plotting, Summarizing, and Methods" section (print/summary/
coef/vcov/as.data.frame methods + edid_weights + edid_weight_plot); and an
"Efficient DiD: Specification Testing and Robustness" section (hausman / sargan /
adaptive / frontier / perturbation_bootstrap / refit_bootstrap).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #260 introduces 16 new exported edid functions, but
_pkgdown.ymlwas never updated.pkgdown::build_site()enforces that every exported topic appears in the reference index, causing thebuild-checkjob to fail.Changes
_pkgdown.yml: Added 3 new reference sections covering all 16 missing topics:edid,aggte_edid,as_MP_edid(alongside existingatt_gt/aggte)print.edid_fit,summary.edid_fit,coef.edid_fit,vcov.edid_fit,as.data.frame.edid_fit,edid_weights,edid_weight_plotedid_hausman,edid_sargan,edid_adaptive,edid_frontier,edid_perturbation_bootstrap,edid_refit_bootstrap