Add proxy matching to adapters that support it.#1126
Open
nialbima wants to merge 1 commit into
Open
Conversation
because Claude? /s |
Author
|
@Nakilon oh absolutely. I reviewed all of the work myself and it's really, really similar to how headers were implemented here, so I felt comfortable opening the PR. But yeah, this was "i need my app to confirm that it actually found the proxy i need it to find, Clerd, have at it." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very-brainless implementation of matching on
proxyfor Webmock. Not all the supported Webmock adapters supported proxy config in an easy way, so I implemented these ones only (the other ones ignore the argument):It's really, really similar to how Webmock implements headers. I added examples to the README, and made sure to cover my work thoroughly (which is why this PR is 500 lines).