fix: throw-safe FTS optimize throttle + hybrid parity docs#158
Merged
Conversation
Commit fts_optimize_last_attempt before optimize so rewrite throws no longer reset the 24h floor. Document MCP hybrid policy-only parity vs service keyword SQL deltas (Kimi wave-6 mediums).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the two medium findings from the Kimi wave-6 review:
EngramDatabaseWriter.optimizeFtsIfDuenow commitsfts_optimize_last_attemptin its own write beforeoptimizeFts. A failing rewrite no longer rolls back the 24h floor (persistent FTS breakage no longer retries every 5-min tick).mcp-tools.mdstate policy parity only (SessionSemanticSearchPolicy+ fuse order), with intentional keyword SQL / filter / orphan deltas documented. Side-by-side test comment matches scope.Test plan
FtsOptimizeCadenceTests4/4 pass (incl.testOptimizeFtsIfDuePersistsAttemptWhenOptimizeThrows_repro)Evidence
Scratch:
wave6-medium-fts-xctest.log