Skip to content

fix: remove deprecated test functions#389

Open
mike-r-harris wants to merge 5 commits into
bbc:mainfrom
mike-r-harris:main
Open

fix: remove deprecated test functions#389
mike-r-harris wants to merge 5 commits into
bbc:mainfrom
mike-r-harris:main

Conversation

@mike-r-harris

@mike-r-harris mike-r-harris commented Jun 20, 2025

Copy link
Copy Markdown

Resolves #NUMBER

Description:
Upgraded Commander from v5 to v7
Updated deprecated test functions

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Why is this change required?:
Keeping changes up to date with latest testing lib versions

Code changes:

  • Updated args.js to ensure Commander returns the correct config
  • Replaced .equal( with .strictEqual(
  • Replaced .notEqual( with .notStrictEqual(
  • Replaced .deepEqual( with .deepStrictEqual(

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mike-r-harris mike-r-harris requested review from a team as code owners June 20, 2025 11:38
Comment thread package.json Outdated
Co-authored-by: Nicholas Griffin <me@nicholasgriffin.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants