Cache built Bazel binaries by commit sha.#144
Open
tjgq wants to merge 1 commit into
Open
Conversation
The commit to build Bazel at can be given as a branch or tag name, which may point to different commits over time. This could cause a previously built Bazel binary to be incorrectly reused.
Member
From reading the documentation in the code, it certainly wasn't the intended usage. If you have a use case for using branch or tag name there, I think the proper thing to do is renaming the |
joeleba
requested changes
Sep 20, 2022
|
|
||
| Args: | ||
| commit: the Bazel commit SHA. | ||
| commit: the commit, branch or tag to build Bazel at. |
Member
There was a problem hiding this comment.
In that case, should this parameter be changed to version_identifier or something, instead of commit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit to build Bazel at can be given as a branch or tag name, which may point to different commits over time. This could cause a previously built Bazel binary to be incorrectly reused.