Refactor/qmad naming - #90
Merged
Merged
Conversation
…ated dependencies in SI_V notebook
…ng .venv directories
Contributor
Author
|
Please don't merge this PR yet... The updated |
…itude damping demo to SI_V notebook
Contributor
Author
|
This pull request is ready to be merged into master. I will submit Part V to JCTC after the merge. |
github-actions
Bot
added
the
documentation
dcabral00
approved these changes
Apr 1, 2026
dcabral00
left a comment
dcabral00
left a comment
Contributor
There was a problem hiding this comment.
Overall changes to the codebase are functionally correct without added maintenance burden.
Contributor
There was a problem hiding this comment.
Execution of cells S.8.2 and S.9.2 is exceedingly slow. It would be good to provide an estimate of execution time above those code cells, for the default parameters.
…9.2 (less trajectories and larger time step) to make execution times more reasonable in Colab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) Changed the names of the following functions in qmad.effh module (to reflect the correct terminology, per Victor's suggestion):
(2) corresponding updates in SI_V notebook