Introduce CORE Api Authentication#40
Open
imRohan wants to merge 1 commit into
Open
Conversation
A new version of the API (CORE) is now available and will be used in the near future for new resources. This new API utilizes a basic authentication scheme. This PR lays the groundwork for future PR's to be able to interact with the CORE api, and adds the plumbing necessary to successfully configure the gem, and authenticate with CORE. This change addresses the need by: * Introducing a v2 authenticator * Introducing a v2 api * Introducing a CoreObject resource which can be used by all core (v2) objects
jmazur
requested changes
Jun 23, 2026
| @authentication = authentication | ||
| end | ||
|
|
||
| def save! |
Collaborator
There was a problem hiding this comment.
why save? i don't think anything is actually being committed anywhere is it? Maybe authenticate! is clearer
Collaborator
Author
There was a problem hiding this comment.
This class has to have the same public interface as the authenticator for v1 which also uses #save! (link). This decision was made initially to make the public api of the classes align with active record. Renaming would impact existing v1 classes, which if necessary should probably be done separately if we're now reconsidering naming.
jmazur
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new version of the API (CORE) is now available and will be used in the near future for new resources. This new API utilizes a basic authentication scheme. This PR lays the groundwork for future PR's to be able to interact with the CORE api, and adds the plumbing necessary to successfully configure the gem, and authenticate with CORE.
This change addresses the need by: