Introduce Update Order Functionality #21
Open
imRohan wants to merge 3 commits into
Open
Conversation
jmazur
requested changes
Mar 26, 2024
jmazur
left a comment
jmazur
left a comment
Collaborator
There was a problem hiding this comment.
The PR looks good, just curious about the decision to make a new method for patch.
chriswoodford
requested changes
Mar 26, 2024
jmazur
approved these changes
Apr 18, 2024
chriswoodford
requested changes
May 30, 2024
| parse_json_file(ERROR_API_RESPONSE) | ||
| end | ||
|
|
||
| def build_stubbed_order |
Contributor
There was a problem hiding this comment.
you're not stubbing anything here. the naming is misleading. you should consider moving this into the factories
chriswoodford
requested changes
Jun 18, 2024
| end | ||
| end | ||
|
|
||
| def request_body |
Contributor
There was a problem hiding this comment.
what's the difference between request_body and update_request_body now?
Contributor
|
@imRohan looks like this needs a rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Partner API v1 has been updated to allow users to update an orders address. Full documentation regarding this new endpoint is available here. We should update this gem to include this new functionality.
This change addresses the need by:
#updatein theIntelligentFoods::OrderresourceOrderNotUpdatedError