feat(preset): localize generated instruction files via the declared language#171
Merged
Conversation
…anguage Completes the i18n pass v0.33.0 started for the views. A repo's preset block follows the repo's OWN declared language (its audience); the view block and the anchor starter follow the ANCHOR entry's language, mirroring the views' rule. ja renders byte-identical to previous releases (locked by full-text goldens); en / en+ja / undeclared render English, the new default. All instruction-file strings move into the single core locale table, shrinking the language-lint E-5 allowlist from three files to one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- A1: correct the CHANGELOG migration note: language-resolution drift surfaces via preset/derive update plans; project check inspects wiring structure, not generated-region content - A2: document the caller-set anchor flag vs the views' path-dot anchor predicate (and first-wins ordering) on resolveAnchorContentLanguage, with a first-wins test - A3: retitle spec 10.0 to cover generated content broadly, sub-head the instruction-file rule, drop the duplicated undeclared case - A4: note the table-selection invariant that makes some source-language label branches unreachable from renders Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
takashi-matsuyama
force-pushed
the
feat/preset-i18n
branch
from
July 13, 2026 15:51
53c9246 to
d565e4a
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the generated-content i18n that v0.33.0 shipped for the four views, extending it to the generated instruction files — the last surface where the author's language leaked into user artifacts (1.0 blocker track).
basou project preset/derive/retrofit): content language follows the repo's own declaredlanguage— its audience.jarenders byte-identical to previous releases;en/en+ja/ undeclared render English (the new default).presetStrings/resolveRepoContentLanguage/resolveAnchorContentLanguage, exported). The language-lint E-5 allowlist shrinks from three files to one (view-strings.ts) — generated Japanese now exists only in the table, enforced by lint.PresetRepo.languagewas already an input; resolution is internal. No signature change forrenderPresetBlock/renderViewPresetBlock;AnchorStarterRepogains an optionallanguagefield (structurally satisfied by existing call sites).ja byte identity
en(e.g. my-favorites greenfield canonicals).Tests
en/en+ja/nothing; deliberate ja-path tests kept and extended (ja renders, en+ja→en floor, anchor-only participation).🤖 Generated with Claude Code