Skip to content

Added tested Ubuntu versions to metadata.json#71

Open
GabrielNicolasAvellaneda wants to merge 3 commits into
basho-labs:masterfrom
GabrielNicolasAvellaneda:master
Open

Added tested Ubuntu versions to metadata.json#71
GabrielNicolasAvellaneda wants to merge 3 commits into
basho-labs:masterfrom
GabrielNicolasAvellaneda:master

Conversation

@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor

Signed-off-by: GabrielNicolasAvellaneda avellaneda.gabriel@gmail.com

Signed-off-by: GabrielNicolasAvellaneda <avellaneda.gabriel@gmail.com>
@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor Author

@danieldreier Added the two Ubuntu versions that I've tested.

@danieldreier

Copy link
Copy Markdown
Collaborator

It looks like the previous PR probably shouldn't have been merged; for some reason it wasn't caught in the testing:

(quoted from the failed travis build):

  1) riak supported operating systems on ubuntu-12.04-x86_64 riak class without any parameters should contain Class[riak::repository::debian]
     Failure/Error: it { is_expected.to contain_class('riak::repository::debian') }
       expected that the catalogue would contain Class[riak::repository::debian]
     # ./spec/classes/riak_spec.rb:33:in `block (6 levels) in <top (required)>'
  2) riak supported operating systems on ubuntu-14.04-x86_64 riak class without any parameters should contain Class[riak::repository::debian]
     Failure/Error: it { is_expected.to contain_class('riak::repository::debian') }
       expected that the catalogue would contain Class[riak::repository::debian]
     # ./spec/classes/riak_spec.rb:33:in `block (6 levels) in <top (required)>'

The issue is that we have a hardcoded test for riak::repository::debian, which obviously doesn't get included on Ubuntu. Would you mind updating that test? I can help if you run into trouble with it.

@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor Author

@danieldreier Sure, I can fix that.

Signed-off-by: GabrielNicolasAvellaneda <avellaneda.gabriel@gmail.com>
Signed-off-by: GabrielNicolasAvellaneda <avellaneda.gabriel@gmail.com>
@GabrielNicolasAvellaneda

Copy link
Copy Markdown
Contributor Author

@danieldreier Don't know what I'm missing. I will try to run the tests locally first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants