chore: replace PR template with Summary/Why/Test-plan format#122
Open
basebandit wants to merge 2 commits into
Open
chore: replace PR template with Summary/Why/Test-plan format#122basebandit wants to merge 2 commits into
basebandit wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go build,go vet,go test -race) so reviewers know exactly what was verified.Why
The old template's generic checklist ("My code follows the style guidelines", "I have performed a self-review") was performative — authors tick boxes without reading, and reviewers gain nothing. The free-form Description had no dedicated Why section, so motivation got buried and PR archaeology suffered six months later. The new format forces the author to state motivation explicitly and verify with real commands.
Test plan