refactor: split storage engine into focused submodules#184
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
BrianBland
force-pushed
the
split-large-files
branch
2 times, most recently
from
January 16, 2026 22:45
31583e0 to
af500aa
Compare
BrianBland
force-pushed
the
split-large-files
branch
from
January 23, 2026 18:29
af500aa to
50b79e0
Compare
refcell
reviewed
Jan 23, 2026
refcell
reviewed
Jan 23, 2026
refcell
reviewed
Jan 23, 2026
refcell
reviewed
Jan 23, 2026
refcell
previously approved these changes
Jan 23, 2026
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
A few non-blocker nits. Otherwise nice refactor!
Split src/storage/engine.rs (3,817 lines) into 8 smaller, focused modules: - mod.rs (142 lines): Core StorageEngine struct and public API - error.rs (43 lines): Error enum and From implementations - read.rs (192 lines): get_account, get_storage, get_value_from_page - write.rs (282 lines): set_values, set_values_in_page, set_values_in_cloned_page - handlers.rs (709 lines): Trie modification handlers (branch/leaf operations) - page_ops.rs (281 lines): allocate, orphan, clone, split pages - helpers.rs (161 lines): Utility functions (prefix matching, subtrie ops) - tests.rs (2,286 lines): Extracted test module
BrianBland
force-pushed
the
split-large-files
branch
from
January 23, 2026 22:35
50b79e0 to
27d7000
Compare
cb-heimdall
dismissed
refcell’s stale review
January 23, 2026 22:35
Approved review 3699899609 from refcell is now dismissed due to new commit. Re-request for approval.
BrianBland
force-pushed
the
split-large-files
branch
from
January 23, 2026 22:37
27d7000 to
5d23e86
Compare
BrianBland
force-pushed
the
split-large-files
branch
from
January 23, 2026 22:51
5d23e86 to
0d93039
Compare
refcell
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split src/storage/engine.rs (3,817 lines) into 8 smaller, focused modules: