Skip to content

fix: always install selected task dependencies - #189

Merged
0xth4nh merged 1 commit into
mainfrom
feat/always-install-task-deps
Aug 5, 2026
Merged

fix: always install selected task dependencies#189
0xth4nh merged 1 commit into
mainfrom
feat/always-install-task-deps

Conversation

@0xth4nh

@0xth4nh 0xth4nh commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What changed?

Always runs make deps from the task selected in the signer UI instead of reusing an existing shared active/evm/lib directory.

The selected task Makefile already runs the shared root deps target, which removes active/evm/lib before installing that task's BASE_CONTRACTS_COMMIT. This also handles switching between tasks in one signer UI session, so contract-deployments no longer needs to purge dependencies in make sign-task.

Checks

npx tsc --noEmit
npm run lint -- --no-cache
npm run build

Co-authored-by: Codex <codex-noreply@coinbase.com>
@cb-heimdall

cb-heimdall commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@0xth4nh
0xth4nh merged commit 1fc7644 into main Aug 5, 2026
6 checks passed
@0xth4nh
0xth4nh deleted the feat/always-install-task-deps branch August 5, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants