Skip to content

feat: install dependencies from selected task - #188

Merged
0xth4nh merged 5 commits into
mainfrom
feat/task-local-dependency-install
Aug 5, 2026
Merged

feat: install dependencies from selected task#188
0xth4nh merged 5 commits into
mainfrom
feat/task-local-dependency-install

Conversation

@0xth4nh

@0xth4nh 0xth4nh commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

What changed?

Runs the existing dependency installation command from the task selected in the signer UI:

- cwd: active/evm
+ cwd: active/evm/tasks/<task-id>

The existing missing-lib check, forceInstall behavior, and make deps command remain unchanged. Each task Makefile owns its BASE_CONTRACTS_COMMIT but sets PROJECT_DIR to the shared active/evm Foundry project, so dependencies still install where script/common expects them.

Checks

npx tsc --noEmit
npm run lint -- --no-cache
npm run build

Co-authored-by: Codex <codex-noreply@coinbase.com>
@cb-heimdall

cb-heimdall commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

0xth4nh and others added 3 commits August 4, 2026 15:55
Co-authored-by: Codex <codex-noreply@coinbase.com>
Co-authored-by: Codex <codex-noreply@coinbase.com>
Co-authored-by: Codex <codex-noreply@coinbase.com>
Comment thread src/app/api/install-deps/route.ts Outdated

const { stdout, stderr } = await execAsync('make deps', {
const { stdout, stderr } = await execAsync(`make -f tasks/${upgradeId}/Makefile deps`, {
cwd: resolvedUpgradePath,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this PR just be a 1-line change here? Use resolvedTaskPath instead of resolvedUpgradePath ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yes! I think we can do that! I think the previous attempt, it tries to match the Makefile's current paths import such as:

../../Makefile      → active/evm/Makefile, which does not exist
tasks/<id>/.env     → tasks/<id>/tasks/<id>/.env
PROJECT_DIR         → tasks/<id>, causing dependencies to install in task/lib

But yah, we don't need to stick with the path and can change it!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in ac879b4. PR #188 is now exactly the one-line cwd: resolvedTaskPath change; the added route test and task-Makefile-specific command were removed. PR #755 now makes the task Makefile self-locating and points PROJECT_DIR/Forge workdir at shared active/evm.

Co-authored-by: Codex <codex-noreply@coinbase.com>
@0xth4nh
0xth4nh merged commit 26f38b7 into main Aug 5, 2026
6 checks passed
@0xth4nh
0xth4nh deleted the feat/task-local-dependency-install branch August 5, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants