feat: install dependencies from selected task - #188
Merged
Conversation
Co-authored-by: Codex <codex-noreply@coinbase.com>
Collaborator
✅ Heimdall Review Status
|
Co-authored-by: Codex <codex-noreply@coinbase.com>
Co-authored-by: Codex <codex-noreply@coinbase.com>
Co-authored-by: Codex <codex-noreply@coinbase.com>
jackchuma
reviewed
Aug 5, 2026
|
|
||
| const { stdout, stderr } = await execAsync('make deps', { | ||
| const { stdout, stderr } = await execAsync(`make -f tasks/${upgradeId}/Makefile deps`, { | ||
| cwd: resolvedUpgradePath, |
Collaborator
There was a problem hiding this comment.
Can't this PR just be a 1-line change here? Use resolvedTaskPath instead of resolvedUpgradePath ?
Contributor
Author
There was a problem hiding this comment.
Ahh yes! I think we can do that! I think the previous attempt, it tries to match the Makefile's current paths import such as:
../../Makefile → active/evm/Makefile, which does not exist
tasks/<id>/.env → tasks/<id>/tasks/<id>/.env
PROJECT_DIR → tasks/<id>, causing dependencies to install in task/lib
But yah, we don't need to stick with the path and can change it!
Contributor
Author
There was a problem hiding this comment.
Done in ac879b4. PR #188 is now exactly the one-line cwd: resolvedTaskPath change; the added route test and task-Makefile-specific command were removed. PR #755 now makes the task Makefile self-locating and points PROJECT_DIR/Forge workdir at shared active/evm.
Co-authored-by: Codex <codex-noreply@coinbase.com>
jackchuma
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Runs the existing dependency installation command from the task selected in the signer UI:
The existing missing-
libcheck,forceInstallbehavior, andmake depscommand remain unchanged. Each task Makefile owns itsBASE_CONTRACTS_COMMITbut setsPROJECT_DIRto the sharedactive/evmFoundry project, so dependencies still install wherescript/commonexpects them.Checks