Fix Windows build: use bash shell for version update step#55
Merged
Conversation
Windows runners use PowerShell by default, which doesn't support bash variable syntax. Adding 'shell: bash' fixes this. Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows build failing with:
Root Cause
Windows runners use PowerShell by default, which doesn't support bash variable syntax like
VERSION="${VERSION#v}".Solution
Add
shell: bashto the version update step to ensure it runs in bash on all platforms.Co-authored-by: openhands openhands@all-hands.dev
@baryhuang can click here to continue refining the PR