chore: replace eslint with biome for linting and formatting#10
Closed
barney-w wants to merge 2 commits into
Closed
chore: replace eslint with biome for linting and formatting#10barney-w wants to merge 2 commits into
barney-w wants to merge 2 commits into
Conversation
Replace the unused ESLint infrastructure (tooling/eslint-config/) with Biome v2 — a Rust-based linter and formatter that is 10-100x faster. - Add biome.json with recommended rules, react domain, and formatter config (single quotes, no semicolons, trailing commas, 2-space indent) - Update root package.json: add @biomejs/biome, replace turbo lint with biome check, add lint:fix and format scripts - Remove lint task from turbo.json (was a no-op since no packages had lint scripts) - Delete tooling/eslint-config/ (private package, never wired up) - Fix all lint violations: add button types, remove unused imports, prefix unused variables, fix forEach return values - Disable noisy a11y rules that conflict with intentional ARIA patterns in this component library (noSvgWithoutTitle, useSemanticElements, noStaticElementInteractions, etc.) - Exclude Tailwind CSS files from biome (uses @theme/@apply directives that biome cannot parse) - Add .git-blame-ignore-revs for the bulk formatting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tooling/eslint-config/) with Biome v2 — a Rust-based linter and formatter that runs in ~65ms across 560 filespackage.jsonscripts:lintnow runsbiome check .directly (no turbo caching needed at this speed), addlint:fixandformatcommandslinttask fromturbo.jsonand deletetooling/eslint-config/(was never wired up — no packages had lint scripts)type="button"to buttons, remove unused imports, prefix unused variables, use template literals, addnode:protocol to Node.js imports@theme/@applydirectives) from biome.git-blame-ignore-revsto skip the bulk formatting commit ingit blame