Harden MarketMind for production readiness - #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit issues
Completed and closed: #176, #177, #178, #179, #180, #181, #182, #183, #184, #185, #186, #187, and #188.
Impact
MarketMind now has a reproducible Node 24/Vite frontend build, production-enforced PostgreSQL and Redis configuration, atomic user-state transitions, a singleton alert worker, bounded external work, stable API contracts, dependency and coverage gates, and a maintainability ceiling that prevents new grade-F Python callables. Local development remains self-contained through a capability-scoped local identity and can use SQL-backed SQLite for features that require relational storage.
Validation
PYTHON_BIN=python3 bash backend/run_deterministic_backend_checks.sh: 204 tests passed, 62% branch-aware coveragepython3 -m pip_audit -r backend/requirements.txt --strict: no known vulnerabilitiesbash frontend/run_frontend_checks.sh: 53 suites and 238 tests passed, all coverage floors passed, Vite production build passednpm audit --audit-level=moderate: zero vulnerabilitiesnpm run test:e2e: Playwright local sign-in, navigation, search, and paper-buy journey passed/healthz,/readyz, local/auth/me, SQL-backed MarketMindAI bootstrap, frontend routing, desktop layout, and responsive DOM passedOperational note
The local live-data smoke encountered Yahoo Finance
429responses for dashboard/screener widgets. Deterministic provider tests and the browser journey pass; the app shell continues rendering and reports the provider failure. The GitHub backend workflow remains authoritative for the Docker image build and PostgreSQL migration smoke.