Deprecation and runtime computation warrning#197
Open
mosesyhc wants to merge 4 commits into
Open
Conversation
Synchronize Feature Branch
jared321
reviewed
May 26, 2026
Contributor
jared321
left a comment
jared321
left a comment
There was a problem hiding this comment.
Some comments/questions.
I still need to run different tests and review action logs as part of the review.
| args=(subinfo), | ||
| method='L-BFGS-B', | ||
| options={'disp': False}, | ||
| # options={'disp': False}, |
Contributor
There was a problem hiding this comment.
Why not delete this line instead of just commenting out?
Member
Author
There was a problem hiding this comment.
Removing the line would be fine.
Contributor
There was a problem hiding this comment.
OK. I will finalize the PR once that line is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues
The deprecation and runtime numerical warnings due to non-invertibility of matrices have been either removed or properly checked.
The
scikit-learnwarning seems to be tied to the use ofRandomForestRegressor. However, the warning seems to be an internal issue wherescikit-learnhas compatibility issue with packages likejoblib. In particular, when spawningParalleldelayed jobs.