Skip to content

fix: conftest deserializator node info #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcamilomolinar merged 2 commits into from
Jun 22, 2026
+4 −4
Merged

fix: conftest deserializator node info #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dffe11
fix: conftest deserializator node info
jcamilomolinar Jun 22, 2026
3996065
fix: conftest deserializator node info test
jcamilomolinar Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ne_sast/engine_iac/src/infrastructure/driven_adapters/conftest/conftest_deserealizator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ def get_list_finding(
msg = failure.get("msg", "unknown")
metadata = failure.get("metadata", {}) or {}
query = metadata.get("query", "unknown")
node_type = metadata.get("node_type", "unknown")
node_id = metadata.get("node_id", "unknown")
where = f"{filename}: {node_type}.{node_id}"
node_type = metadata.get("node_type")
node_id = metadata.get("node_id")
where = f"{filename}: {node_type}.{node_id}" if node_type and node_id else filename

rule_id = metadata.get("id", "")
rule_meta = rules_lookup.get(rule_id, {})
Expand Down
2 changes: 1 addition & 1 deletion ...t/engine_iac/test/infrastructure/driven_adapters/conftest/test_conftest_deserealizator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_get_list_finding_single_failure(self):
finding = findings[0]
self.assertEqual(finding.id, "data.main.deny") # no metadata.id → fallback to query
self.assertEqual(finding.description, "Containers must not run as root")
self.assertEqual(finding.where, "deploy.yaml: unknown.unknown")
self.assertEqual(finding.where, "deploy.yaml")
self.assertEqual(finding.severity, "high")
self.assertEqual(finding.category, Category.VULNERABILITY)
self.assertEqual(finding.tool, "Conftest")
Expand Down
Loading