Skip to content

fix: icon loader #32

Merged
juan-campuzano merged 5 commits into
mainfrom
fix/icon-loader
May 11, 2026
Merged

fix: icon loader #32
juan-campuzano merged 5 commits into
mainfrom
fix/icon-loader

Conversation

@juan-campuzano

Copy link
Copy Markdown
Collaborator

Golden test font loading improvements:

  • Added an optional currentPackage parameter to loadConfiguration and loadAppFonts to register icon fonts under the packages/<currentPackage>/<family> alias, ensuring correct rendering when testing from within the package itself. [1] [2] [3] [4] [5]
  • Updated the logic in fontFamilyAliases to generate the correct aliases for fonts when currentPackage is provided, handling local asset paths and avoiding duplicate or unnecessary aliases.

Documentation updates:

  • Added clear documentation in README.md and skills/bc_golden_testing/SKILL.md explaining when and how to use the currentPackage parameter for golden tests involving package-owned icon fonts. [1] [2]
  • Updated the CHANGELOG.md and pubspec.yaml to reflect the new version and describe the new parameter. [1] [2]

Testing:

  • Added comprehensive tests to verify that the new aliasing logic works as intended for various font scenarios, including local fonts, system fonts, and fonts with existing packages/ prefixes. [1] [2]

@juan-campuzano juan-campuzano merged commit 77fcf6c into main May 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants