fix: update device resolutions#30
Merged
Merged
Conversation
santicalleg
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #28
Device configuration updates:
GoldenDeviceDatafor devices such asiPhone16ProMax,nothingPhone3,galaxyS25,androidFHDplus,iPhoneStandard, andandroidQHDplusto use logical pixel sizes (dp/pt) and device pixel ratios (DPR) instead of native pixel dimensions and PPI. Added clarifying comments to explain the new sizing logic.Test updates for new sizing logic:
golden_device_data_test.dartto expect the new logical sizes and DPR values for each device, ensuring tests reflect the updated configuration. [1] [2] [3] [4] [5]440 * 3.0instead of1320 * 460.0).