Skip to content

fix: update device resolutions#30

Merged
juan-campuzano merged 2 commits into
mainfrom
fix/device-resolution
May 5, 2026
Merged

fix: update device resolutions#30
juan-campuzano merged 2 commits into
mainfrom
fix/device-resolution

Conversation

@juan-campuzano

Copy link
Copy Markdown
Collaborator

resolve #28

Device configuration updates:

  • Updated GoldenDeviceData for devices such as iPhone16ProMax, nothingPhone3, galaxyS25, androidFHDplus, iPhoneStandard, and androidQHDplus to use logical pixel sizes (dp/pt) and device pixel ratios (DPR) instead of native pixel dimensions and PPI. Added clarifying comments to explain the new sizing logic.

Test updates for new sizing logic:

  • Modified all relevant tests in golden_device_data_test.dart to expect the new logical sizes and DPR values for each device, ensuring tests reflect the updated configuration. [1] [2] [3] [4] [5]
  • Updated tests for physical size calculations to use the new logical size and DPR values (e.g., 440 * 3.0 instead of 1320 * 460.0).
  • Adjusted tests for view insets and padding to match the new DPR-based calculations. [1] [2]

@juan-campuzano juan-campuzano merged commit 652d051 into main May 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Samsung Galaxy S25 resolution too big in tests

2 participants