Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/build-client-dart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
uses: bancolombia/flutter-setup-action@v1.1
with:
channel: 'stable'
flutter-version: '3.35.0'
flutter-version: '3.44.0'
- name: Install dependencies
run: flutter pub get
- name: Run test
Expand All @@ -42,20 +42,21 @@ jobs:
uses: bancolombia/flutter-setup-action@v1.1
with:
channel: 'stable'
flutter-version: '3.35.0'
flutter-version: '3.44.0'

- name: Install Dependencies
run: |
sudo apt-get update
sudo apt-get install -y webp
dart pub get
flutter pub get
dart pub global activate pana

- name: Verify Pub Score
run: |
dart --version
flutter --version
PANA=$(pana . --no-warning); PANA_SCORE=$(echo $PANA | sed -n "s/.*Points: \([0-9]*\)\/\([0-9]*\)./\1\/\2/p")
FLUTTER_SDK="$(dirname "$(dirname "$(which flutter)")")"
PANA=$("$HOME/.pub-cache/bin/pana" . --no-warning --flutter-sdk "$FLUTTER_SDK" --dartdoc-version sdk); PANA_SCORE=$(echo $PANA | sed -n "s/.*Points: \([0-9]*\)\/\([0-9]*\)./\1\/\2/p")
echo "score: $PANA_SCORE"
IFS='/'; read -a SCORE_ARR <<< "$PANA_SCORE"; SCORE=${SCORE_ARR[0]}; TOTAL=${SCORE_ARR[1]}
if (( $SCORE < $TOTAL - 30 )); then echo $PANA; echo "minimum score not met!"; exit 1; fi
2 changes: 1 addition & 1 deletion .github/workflows/release-client-dart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: bancolombia/flutter-setup-action@v1.1
with:
channel: 'stable'
flutter-version: '3.35.0'
flutter-version: '3.44.0'
- name: Install dependencies
run: dart pub get
- name: Publish to pub.dev
Expand Down
2 changes: 2 additions & 0 deletions clients/client-dart/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# CHANGELOG
## [3.2.1]
- Update dependencies to major versions
## [3.2.0]
- Add deduplication support for ws.
## [3.1.1]
Expand Down
21 changes: 0 additions & 21 deletions clients/client-dart/LICENCE

This file was deleted.

12 changes: 6 additions & 6 deletions clients/client-dart/LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License
MIT License

Copyright (c) 2019 Bancolombia S.A
Copyright (c) 2021 Bancolombia S.A.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand All @@ -9,13 +9,13 @@ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
82 changes: 5 additions & 77 deletions clients/client-dart/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ linter:
comment_references: false
one_member_abstracts: false
only_throw_errors: true
package_api_docs: true
prefer_single_quotes: true
sort_child_properties_last: true
camel_case_types: true
Expand Down Expand Up @@ -74,8 +73,10 @@ analyzer:
exclude:
- "**.mocks.dart"
- "**.g.dart"
plugins:
- dart_code_linter


plugins:
dart_code_linter: ^4.1.5

dart_code_linter:
metrics:
Expand All @@ -85,77 +86,4 @@ dart_code_linter:
number-of-parameters: 4
source-lines-of-code: 250
metrics-exclude:
- test/**
rules:
- avoid-non-null-assertion
- avoid-dynamic
- avoid-returning-widgets
- avoid-nested-conditional-expressions
- avoid-unnecessary-type-casts
- avoid-unnecessary-conditionals
- avoid-unused-parameters:
severity: none
- missing-test-assertion
- newline-before-return:
severity: none
- no-boolean-literal-compare
- no-empty-block
- no-equal-then-else
- no-magic-number
- prefer-trailing-comma:
severity: none
- prefer-conditional-expressions
- prefer-immediate-return
- prefer-moving-to-variable
- format-comment:
only-doc-comments: true
- member-ordering:
order:
- public-fields
- private-fields
- constructors
- close-method
- dispose-method
widgets-order:
- constructor
- build-method
- init-state-method
- did-change-dependencies-method
- did-update-widget-method
- dispose-method

- always-remove-listener
- avoid-unnecessary-setstate
- prefer-extracting-callbacks
- prefer-using-list-view
- avoid-ignoring-return-values:
severity: none
- avoid-passing-async-when-sync-expected:
exclude:
- test/**
- avoid-unnecessary-type-assertions
- avoid-unrelated-type-assertions
- double-literal-format
- prefer-async-await
- prefer-correct-identifier-length:
max-identifier-length: 35
min-identifier-length: 2
- prefer-correct-test-file-name
- prefer-correct-type-name:
min-length: 3
max-length: 35
- prefer-first
- prefer-last
- prefer-match-file-name:
exclude:
- test/**
- avoid-border-all
- avoid-expanded-as-spacer
- avoid-wrapping-in-padding
- no-blank-line-before-single-return
- prefer-first-or-null
- prefer-single-quotes

anti-patterns:
- long-method
- long-parameter-list
- test/**
Loading
Loading