Skip to content

fix: sse dynamic import#145

Merged
juancgalvis merged 14 commits into
masterfrom
fix/sse-dynamic-import
May 22, 2026
Merged

fix: sse dynamic import#145
juancgalvis merged 14 commits into
masterfrom
fix/sse-dynamic-import

Conversation

@gabheadz

Copy link
Copy Markdown
Contributor

Description

Category

  • Feature
  • Fix

Checklist

  • The pull request is complete according to the guide of contributing
  • Automated tests are written
  • The documentation is up-to-date
  • the version of the mix.exs was increased
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog

@gabheadz gabheadz changed the title Fix/sse dynamic import fix: sse dynamic import Apr 18, 2026
@Ferla04

Ferla04 commented Apr 20, 2026

Copy link
Copy Markdown

Good morning,

Since this is for v5.0.0, we should address the ESM migration. I noticed the tsconfig is like this,
image

won't work as expected because package.json is missing "type": "module", causing it to still compile to CJS.

This migration can be tricky (see this CHANGES for reference). Have you considered using tsup(bundler) instead of tsc? It might be a smoother way to handle the ESM/CJS compatibility without having to refactor as much code.

@diana-suasnavas diana-suasnavas force-pushed the fix/sse-dynamic-import branch from bc8423e to 06c4572 Compare May 6, 2026 22:51
@sonarqubecloud

sonarqubecloud Bot commented May 8, 2026

Copy link
Copy Markdown

@juancgalvis juancgalvis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work

@juancgalvis juancgalvis merged commit db79f12 into master May 22, 2026
6 checks passed
@juancgalvis juancgalvis deleted the fix/sse-dynamic-import branch May 22, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(client-js): node:diagnostics_channel error when bundling with Webpack in microfrontend environments

4 participants