FIX: avoid debug asserts in multifilament project loading#10547
Open
altendky wants to merge 1 commit intobambulab:masterfrom
Open
FIX: avoid debug asserts in multifilament project loading#10547altendky wants to merge 1 commit intobambulab:masterfrom
altendky wants to merge 1 commit intobambulab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrintObject::object_extruders()values as 0-based filament indexes in by-object multifilament validation.Details
PrintObject::object_extruders()returns 0-based filament indexes, so0is valid and represents the first filament. The by-object branch inPrint::check_multi_filament_valid()incorrectly asserted that each returned extruder index was greater than zero, causing debug builds to abort while loading valid multifilament.3mfprojects.The fix removes that invalid assertion and uses an unsigned local set matching the returned index type.
Testing
git diff --check master...HEADNotes