FIX: StatusPanel, show current-print thumbnail on wxGTK#10348
Open
ClusterM wants to merge 1 commit intobambulab:masterfrom
Open
FIX: StatusPanel, show current-print thumbnail on wxGTK#10348ClusterM wants to merge 1 commit intobambulab:masterfrom
ClusterM wants to merge 1 commit intobambulab:masterfrom
Conversation
On Linux (wxGTK) wxStaticBitmap is a native GtkImage wrapper and does not dispatch wxEVT_PAINT to Bind()'d handlers. As a result, the PrintingTaskPanel::paint() override that wxMSW/wxOSX rely on to composite m_thumbnail_bmp_display over the panel is never invoked, and set_thumbnail_img() has no visible effect - the placeholder sent to the widget at construction time stays on screen for the whole session. Push the bitmap through the widget's native SetBitmap() path in addition to the existing Refresh() so the new image shows up on all platforms regardless of whether wxEVT_PAINT fires.
Author
|
Rebased/fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux (wxGTK) wxStaticBitmap is a native GtkImage wrapper and does
not dispatch wxEVT_PAINT to Bind()'d handlers. As a result, the
PrintingTaskPanel::paint() override that wxMSW/wxOSX rely on to
composite m_thumbnail_bmp_display over the panel is never invoked, and
set_thumbnail_img() has no visible effect - the placeholder sent to
the widget at construction time stays on screen for the whole session.
Push the bitmap through the widget's native SetBitmap() path in
addition to the existing Refresh() so the new image shows up on all
platforms regardless of whether wxEVT_PAINT fires.