Skip to content

FIX: Guard m_side_window against null/stale pointer in ObjectGridTable (fixes Flatpak crash on 'View all object settings') #10303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tinezivic wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −8
Open

FIX: Guard m_side_window against null/stale pointer in ObjectGridTable (fixes Flatpak crash on 'View all object settings') #10303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee817c7
FIX: Guard m_side_window against null/stale pointer in ObjectGridTable
tinezivic Apr 20, 2026
821ec5f
FIX: null m_side_window before Clear(true) in destructor to close rac…
tinezivic Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/slic3r/GUI/GUI_ObjectTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2554,9 +2554,11 @@ bool ObjectGridTable::OnCellLeftClick(int row, int col, ConfigOptionType &type)
//update the right side setting list
bool is_object = (grid_row->row_type == row_object);
ModelObject* object = m_panel->m_model->objects[grid_row->object_id];
m_panel->m_side_window->Freeze();
m_panel->m_object_settings->ValueChanged(row, is_object, object, grid_row->config, grid_col_2->category, grid_col_2->key);
m_panel->m_side_window->Thaw();
if (m_panel->m_side_window) {
m_panel->m_side_window->Freeze();
m_panel->m_object_settings->ValueChanged(row, is_object, object, grid_row->config, grid_col_2->category, grid_col_2->key);
m_panel->m_side_window->Thaw();
}
//m_panel->m_plater->update();
}
else {
Expand All @@ -2575,6 +2577,8 @@ bool ObjectGridTable::OnCellLeftClick(int row, int col, ConfigOptionType &type)
void ObjectGridTable::OnSelectCell(int row, int col)
{
m_selected_cells.clear();
if (!m_panel->m_side_window)
return;
m_panel->m_side_window->Freeze();
if (row == 0 || col == col_filaments) {
m_panel->m_object_settings->UpdateAndShow(row, false, false, false, nullptr, nullptr, std::string());
Expand Down Expand Up @@ -2651,11 +2655,11 @@ void ObjectGridTable::OnCellValueChanged(int row, int col)
bool is_object = (grid_row->row_type == row_object);
ModelObject* object = m_panel->m_model->objects[grid_row->object_id];

m_panel->m_side_window->Freeze();

m_panel->m_object_settings->ValueChanged(row, is_object, object, grid_row->config, grid_col->category, grid_col->key);

m_panel->m_side_window->Thaw();
if (m_panel->m_side_window) {
m_panel->m_side_window->Freeze();
m_panel->m_object_settings->ValueChanged(row, is_object, object, grid_row->config, grid_col->category, grid_col->key);
m_panel->m_side_window->Thaw();
}
//update volume cell
/*if (is_object) {
int next_row = row + 1;
Expand Down Expand Up @@ -3171,6 +3175,7 @@ ObjectTablePanel::~ObjectTablePanel()
delete m_object_grid_table;
m_object_grid_table = nullptr;
}*/
m_side_window = nullptr; // null before Clear(true) — pending events hit the guard safely
if (m_top_sizer)
m_top_sizer->Clear(true);
delete m_object_settings;
Expand Down