Skip to content

[0.7] Intermedium Between - #115

Merged
kaioken merged 1 commit into
0.7from
feature-between-patch
Apr 19, 2021
Merged

[0.7] Intermedium Between#115
kaioken merged 1 commit into
0.7from
feature-between-patch

Conversation

@kaioken

@kaioken kaioken commented Apr 14, 2021

Copy link
Copy Markdown
Member

While opendistro sql driver adds support for the BETWEEN lexico , we will have to implement a patch to use >= <=
opendistro-for-elasticsearch/sql#1067

@todo

todo Bot commented Apr 14, 2021

Copy link
Copy Markdown

add findFirst and Find() like phalcon

* @todo add findFirst and Find() like phalcon
*
* @param string $sql
*
* @return array


This comment was generated by todo based on a todo comment in 010eca9 in #115. cc @bakaphp.

@todo

todo Bot commented Apr 14, 2021

Copy link
Copy Markdown

temp solution to handle between while this pull is merged opendistro-for-elasticsearch/sql#1067

* @todo temp solution to handle between while this pull is merged https://github.com/opendistro-for-elasticsearch/sql/pull/1067
*/
$comparison .= $operator == '>' ? ' AND ' . $field . ' <= ' . $value : ' OR ' . self::buildComparison($field, $operator, $value);
//$comparison .= $operator == 'BETWEEN' ? ' AND ' . $value : ' OR ' . self::buildComparison($field, $operator, $value);
}


This comment was generated by todo based on a todo comment in 010eca9 in #115. cc @bakaphp.

@kaioken
kaioken requested review from FredPeal and dasdo April 14, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants