Skip to content

highflip-editor:init and add access log aop for web api#5

Open
TingSty wants to merge 17 commits into
baidu:1.0.0from
TingSty:1.0
Open

highflip-editor:init and add access log aop for web api#5
TingSty wants to merge 17 commits into
baidu:1.0.0from
TingSty:1.0

Conversation

@TingSty

@TingSty TingSty commented Apr 23, 2023

Copy link
Copy Markdown
Collaborator

No description provided.

songtingyu and others added 8 commits April 11, 2023 16:47
2.add the convert of ListProto to java List and MapProto to java Map
3.modify the uuid strategy
4.register highflip runtime oject
5.complete HighFlipService
6.add highflip.adaptor.service.properties
spring.datasource.driver-class-name=org.h2.Driver
spring.datasource.url=jdbc:h2:file:~/.highflip/db/highflip.db
spring.datasource.url=jdbc:h2:file:~/.highflip/db/highflip
spring.datasource.username=highflip

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方不用加认证,本地文件数据库

void initialDefaultAdaptor() {
DefaultAdaptor adaptor = new DefaultAdaptor();
adaptor.setup(register);
register.register(InstanceNameList.HIGHFLIP_RUNTIME, highFlipRuntime);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

放到DefaultAdaptor初始化

rpc controlPartner(PartnerControlRequest) returns(Void);

// adaptor service config
rpc getServiceConfig(Void) returns(GetServiceConfigResponse);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用getConfig是不是可以?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块就不需要单独的接口了

Comment thread highflip-editor/pom.xml Outdated
<jmockit.version>1.43</jmockit.version>
<guava.version>31.1-jre</guava.version>
<spring.security.version>6.0.2</spring.security.version>
</properties>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些是不是可以继承父的工程属性,不需要单独设置

@@ -0,0 +1,10 @@
package com.baidu.highflip.core.adaptor;

public interface ServiceAdaptor {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以考虑放到config中

@Id
@Column(name = "data_id", length = 36)
@GenericGenerator(name = "id_gen", strategy = "uuid2")
@Column(name = "data_id", length = 72)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

长度是不是过长了

@TingSty

TingSty commented Aug 1, 2023 via email

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants